[PATCH 2/2] openssl: Fix unused variable compiler warning on fedora 17

[Ben Greear via curl-library]

From: Ben Greear <***@candelatech.com>

ctx_options was not used, so the compiler warned. Add
a (void)(ctx_options) line to make the compiler happy.

Hopefully that is the right fix...

Signed-off-by: Ben Greear <***@candelatech.com>
---
lib/vtls/openssl.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/lib/vtls/openssl.c b/lib/vtls/openssl.c
index 720e87d..a3041b4 100644
--- a/lib/vtls/openssl.c
+++ b/lib/vtls/openssl.c
@@ -2167,6 +2167,7 @@ set_ssl_version_min_max(long *ctx_options, struct connectdata *conn,
}
#else
(void)sockindex;
+ (void)ctx_options;
failf(data, OSSL_PACKAGE " was built without TLS 1.3 support");
return CURLE_NOT_BUILT_IN;
#endif

[Daniel Stenberg via curl-library]

i = part;
- for(o = enc; *i; ++o, ++i)
- *o = (*i == ' ') ? '+' : *i;
+ for(o = enc; *i; ++o, ++i) {
+ if (*i == ' ')
+ *o = '+';
+ else
+ *o = *i;
+ }

This is a broken compiler that warns about this. I really prefer the existing
one-line version to this 4-line replacement.

[Ben Greear via curl-library]

i = part;
- for(o = enc; *i; ++o, ++i)
- *o = (*i == ' ') ? '+' : *i;
+ for(o = enc; *i; ++o, ++i) {
+ if (*i == ' ')
+ *o = '+';
+ else
+ *o = *i;
+ }

This is a broken compiler that warns about this. I really prefer the existing one-line version to this 4-line replacement.

Well yes, it would be great if the compiler wasn't broken, but still nice to
allow curl to compile (with -Werror) on weird/broken-ish compilers.

I think a few lines of extra code is a small price to pay.

Thanks,
Ben

[Ben Greear via curl-library]

This is a broken compiler that warns about this. I really prefer the existing one-line version to this 4-line replacement.

Well yes, it would be great if the compiler wasn't broken, but still nice to allow curl to compile (with -Werror) on weird/broken-ish compilers.
I think a few lines of extra code is a small price to pay.

Everything's a ballance of course. What's the price/benefit trade-off?
We would gain an ancient compiler to build warning-free at the price of slightly less readable code (which of course is debatable and we could argue how much of a problem it would be, but I also don't want to open the flood gates for fixing warnings when it is so obviously wrong in the compiler).
In this case, it seems mostly one or two persons will gain from fixing the build for the ancient compiler (that even could be updated) while more than one or two persons will potentially risk something by needlessly complicating the code.
So my stance on this patch is still: thanks, but no thanks.

Ok, thanks for considering it.

Ben

[Daniel Stenberg via curl-library]

ctx_options was not used, so the compiler warned. Add a (void)(ctx_options)
line to make the compiler happy.

What OpenSSL version do you have installed to get this warning? Maybe it
should rather disable set_ssl_version_min_max() completely?

[Ben Greear via curl-library]

ctx_options was not used, so the compiler warned. Add a (void)(ctx_options) line to make the compiler happy.

What OpenSSL version do you have installed to get this warning? Maybe it should rather disable set_ssl_version_min_max() completely?

rpm -qa | grep openssl
...
openssl-1.0.0k-1.fc17.i686
openssl-devel-1.0.0k-1.fc17.i686

Before I rebased, it compiled OK, so I guess there was some change in that
code to cause the warning. I do not know enough about what it is trying to do
to be certain of the proper fix.

Thanks,
Ben

[Daniel Stenberg via curl-library]

Post by Ben Greear via curl-library
Before I rebased, it compiled OK, so I guess there was some change in that
code to cause the warning. I do not know enough about what it is trying to
do to be certain of the proper fix.

I've pushed it here: https://github.com/curl/curl/pull/3347